Add SysV semaphore constants #4286
Open
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Feb 26, 2025
src/unix/linux_like/linux/mod.rs
Outdated
| @@ -2979,6 +2979,19 @@ pub const MSG_NOERROR: c_int = 0o10000; | |||
| pub const MSG_EXCEPT: c_int = 0o20000; | |||
| pub const MSG_ZEROCOPY: c_int = 0x4000000; | |||
|
|
|||
| pub const SEM_UNDO: c_int = 4096; | |||
There was a problem hiding this comment.
Could you change the literal to 0x1000 to match the Linux header? Please squash after, otherwise lgtm
bertptrs
force-pushed
the
sysv-semaphore-constants
branch
from
3dacbcd to
cb8c0ba
Compare
tgross35
force-pushed
the
sysv-semaphore-constants
branch
from
cb8c0ba to
f84f618
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds missing constants required to use the SysV semaphore system, fixes #4264. Arguably, most of these constants should be
c_shortrather thanc_int, as that is how they are used, but they already exist for other UNIXes asc_intso I opted to be consistent with those.Sources
Definitions: https://github.com/torvalds/linux/blob/cc8a0934d099b8153fc880a3588eec4791a7bccb/include/uapi/linux/sem.h#L7-L22
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI